Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpamAssassain - Header and body test - Add additional information about test syntax #960

Open
shoulders opened this issue Nov 10, 2024 · 3 comments

Comments

@shoulders
Copy link

SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.5
Usermin version 2.102
Virtualmin version 7.20.2 Pro
Theme version 21.20.7
Apache version 2.4.52
Package updates 49 package updates are available

Background

The issue

You are able to make and submit rules that do no follow the required convention:

https://spamassassin.apache.org/full/3.1.x/doc/Mail_SpamAssassin_Conf.html

Proposed solution

I would like to add the following text (from the SpamAssassain Docs) to the top of the Header and body tests page to help use the correct syntax.

This will be a useful stop gap because there is no form validation which is what users would expect.

Test names must not start with a number, and must contain only alphanumerics and underscores. It is suggested that lower-case characters not be used, and names have a length of no more than 22 characters, as an informal convention. Dashes are not allowed.

image

@jcameron
Copy link
Collaborator

Instead of that message, couldn't we just block rules with invalid names from being added?

@shoulders
Copy link
Author

Would be better + a link maybe.

But I am sure @iliajie said it would be difficult because of UI limitations.

@iliajie
Copy link
Collaborator

iliajie commented Nov 10, 2024

I think what Jamie meant was that we can implement server-side validation and simply throw an error if a field isn’t set correctly or is left empty... We don’t actually need to do client-side validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants