Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for the README #9

Closed
RonaldEnsing opened this issue Jul 14, 2021 · 3 comments · Fixed by #11
Closed

Suggestions for the README #9

RonaldEnsing opened this issue Jul 14, 2021 · 3 comments · Fixed by #11
Assignees

Comments

@RonaldEnsing
Copy link

Related to openjournals/joss-reviews#3471.

I'd recommend to add links to refer to some things mentioned in the readme. For example:

No default tag latest is defined for the https://hub.docker.com/repository/docker/tgoelles/pointcloudset image, so a docker pull tgoelles/pointcloudset will not work. A tag would need to be specified by the user. Is this done intentionally? In that case I think that it would be good to write the exact docker pull command in the readme.

The Quickstart example shows a code snippet that refers to rosbag_file.bag and lasfile.las. Are these files available somewhere? Would it be possible to include a quickstart example with existing example files - and ideally - some example output that includes the visualizations as shown in the README?

@tgoelles
Copy link
Collaborator

Yes links are certainly a good idea.

Yes I avoided the latest tag since it can cause some confusion. But, I think I can easily add it to github actions to tag it both with the version name and latest.

The quickstart example is only there to give a quick idea what the API looks like. For working examples of code please see usage.ipynb. Do you think that the user expects working examples in the README or just a general idea of what the API looks like?

I also want to change the sphinx setup to run the notebooks so that notebook is populated with results and plots. This would also improve the html documentation.

@RonaldEnsing
Copy link
Author

Yes I avoided the latest tag since it can cause some confusion. But, I think I can easily add it to github actions to tag it both with the version name and latest.

I think that would be nice. I expect that most users will do a docker pull without specifying or looking into versions and expect it to work. Especially when they are only exploring the package to see if it is useful to them.

Do you think that the user expects working examples in the README or just a general idea of what the API looks like?

I'd expect a working example. If the quickstart is only meant to show a general idea, then what general idea do you want to show specifically? It only shows the file I/O. I think it would be nice if a quickstart allows someone to reproduce the Figures under 'Features' in the README. If that would make the README too cluttered, then maybe a link to a notebook on how to produce these Figures?

I also want to change the sphinx setup to run the notebooks so that notebook is populated with results and plots. This would also improve the html documentation.

Sounds good! I think the notebooks are somewhat 'hidden' in the docs directory. Maybe it would help to add a link from the README to the notebooks to increase the discoverability of the notebooks.

@tgoelles tgoelles self-assigned this Jul 15, 2021
@tgoelles tgoelles linked a pull request Jul 15, 2021 that will close this issue
@tgoelles
Copy link
Collaborator

We fixed everything except a problem with updating documentation from notebooks remains. See issue #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants