Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and docker image #71

Open
mrrevillo0815 opened this issue Jul 26, 2023 · 3 comments
Open

Update documentation and docker image #71

mrrevillo0815 opened this issue Jul 26, 2023 · 3 comments
Assignees
Labels
docker everything related to the docker documentation Improvements or additions to documentation

Comments

@mrrevillo0815
Copy link

mrrevillo0815 commented Jul 26, 2023

The ROS2 Support works great! Two things that would be good to change now:

  • It would be just good to update the docker image on docker hub to use Pointcloudset 0.9.0
  • In the documentation: add the information that, when using ros2, you should use the folder where the metadata and the ros2 bag file is and not the file itself. (Or change the code behavior to look for the metadata file in the same folder as the ros2bag file.)
@tgoelles tgoelles added documentation Improvements or additions to documentation docker everything related to the docker labels Jul 31, 2023
@tgoelles
Copy link
Collaborator

Good to get feedback on the ROS2 support.

This is also related to #69 an issue with the GitHub action that builds the docker images.

Yes I will look into changing the code behavior or just update the documentation.

@tgoelles tgoelles self-assigned this Jul 31, 2023
@tgoelles
Copy link
Collaborator

tgoelles commented Dec 3, 2024

Now the new version 0.10.0 solves this. @mrrevillo0815 can you maybe point at the location in the documentation or make an PR?

@mrrevillo0815
Copy link
Author

Thank you for the Update, I am sure it will help the people that will use your tool in the future. 😊

Sadly I do not work with this setup anymore and do not have a PC where I can run this.

But I'll look over it when I find time during the Week! 😁

Regards,
Oliver 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker everything related to the docker documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants