-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Communities] ValidationChallenge trait #321
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandres95
changed the base branch from
master
to
feature/pandres95-communities-pallet
November 9, 2023 16:24
pandres95
force-pushed
the
294-validating-a-community-challenge
branch
from
November 19, 2023 15:54
1d26bc7
to
9bd25c2
Compare
* change(runtime/kreivo): add pallet-communities as dep * change(pallets/communities): set sp-runtime as dep to support StaticLookup * feat(pallet/communities): checks for community state * feat(pallets/communities): check for permissioned calls * feat(pallets/communities): implement add_member * change(pallets/communities): use try_mutate_exists on do_insert_member * chore(community:tests): remove redundant submod * feat(pallets/communities): implement remove_member * change(pallets/communities): update documentation * change(communities:Cargo): update package metadata * fix(pallets/communities): apply clippy suggestions * change(pallet/communities): update docs * fix(communities:remove_member): make sure that origin is being checked on first * chore(pallets/communities): explicit naming for functions that ensure origin
* change(runtime/kreivo): add pallet-communities as dep * change(pallets/communities): set sp-runtime as dep to support StaticLookup * feat(pallet/communities): checks for community state * feat(pallets/communities): check for permissioned calls * feat(pallets/communities): implement add_member * change(pallets/communities): use try_mutate_exists on do_insert_member * chore(community:tests): remove redundant submod * feat(pallets/communities): implement remove_member * change(pallets/communities): update documentation * change(communities:Cargo): update package metadata * fix(pallets/communities): apply clippy suggestions * change(pallet/communities): update docs * fix(communities:remove_member): make sure that origin is being checked on first * chore(pallets/communities): explicit naming for functions that ensure origin
* chore(communities:tests): remove qualified references to sp_runtime::DispatchError * refactor(communities:functions): simplify qualified references to types and traits * feat(pallets/communities): implement assets_transfer * feat(pallets/communities): implement balance_transfer * chore(pallets/communities): update docs * fix(communities:functions/tokens): apply fmt * refactor(communities:functions/tokens): rename mod to treasury * refactor(communities:functions): move do_create_community_account to treasury module * chore(communities:functions/registration): rename as registry * m:change(communities:registry): directly override value on do_set_metadata
* refactor(pallets/communities): resolve ambiguity between CommunityMetadata storage type and struct * refactor(pallets/communities): split logical modules within pallet * refactor(communities:pallet): use pallet::call(weight) option * refactor(pallet/communities): remove excessive verbosity * change(pallet/communities): update documentation regarding tokens * refactor(pallets/communities): split types into multiple files
* feat(pallets/communities): define MemberRank trait, for MembershipPassport * feat(pallets/communities): add structures and storage for handling governance * feat(pallets/communities): add governance (polls/proposals) handling functions * feat(pallets/communities): define open_proposal/execute_call * change(pallets/communities): explictly state call origin when creating proposal * fix(pallets/communities): lint * change(communities:functions/origin): use CheckedConversion to replace as_origin!
olanod
force-pushed
the
feature/pandres95-communities-pallet
branch
from
November 21, 2023 16:29
12f2f6b
to
14ecf35
Compare
pandres95
force-pushed
the
294-validating-a-community-challenge
branch
from
November 22, 2023 16:06
1836eac
to
d5ef412
Compare
* feat(pallets/communities): define member_rank traits * change(pallets/communities): split membership and member_rank feat(communities:functions): implement do_promote and do_demote * feat(pallet/communities): define/implement promote_member and demote_member * Use specific Rank type instead of generic --------- Co-authored-by: Daniel Olano <[email protected]>
pandres95
force-pushed
the
feature/pandres95-communities-pallet
branch
from
November 24, 2023 16:38
74f8b61
to
ff53773
Compare
* change(runtime/kreivo): add pallet-communities as dep * change(pallets/communities): set sp-runtime as dep to support StaticLookup * feat(pallet/communities): checks for community state * feat(pallets/communities): check for permissioned calls * feat(pallets/communities): implement add_member * change(pallets/communities): use try_mutate_exists on do_insert_member * chore(community:tests): remove redundant submod * feat(pallets/communities): implement remove_member * change(pallets/communities): update documentation * change(communities:Cargo): update package metadata * fix(pallets/communities): apply clippy suggestions * change(pallet/communities): update docs * fix(communities:remove_member): make sure that origin is being checked on first * chore(pallets/communities): explicit naming for functions that ensure origin
* change(runtime/kreivo): add pallet-communities as dep * change(pallets/communities): set sp-runtime as dep to support StaticLookup * feat(pallet/communities): checks for community state * feat(pallets/communities): check for permissioned calls * feat(pallets/communities): implement add_member * change(pallets/communities): use try_mutate_exists on do_insert_member * chore(community:tests): remove redundant submod * feat(pallets/communities): implement remove_member * change(pallets/communities): update documentation * change(communities:Cargo): update package metadata * fix(pallets/communities): apply clippy suggestions * change(pallet/communities): update docs * fix(communities:remove_member): make sure that origin is being checked on first * chore(pallets/communities): explicit naming for functions that ensure origin
pandres95
force-pushed
the
294-validating-a-community-challenge
branch
from
November 24, 2023 16:58
d5ef412
to
63579bb
Compare
olanod
force-pushed
the
feature/pandres95-communities-pallet
branch
3 times, most recently
from
December 4, 2023 23:51
2131547
to
db5da4a
Compare
Base automatically changed from
feature/pandres95-communities-pallet
to
master
December 4, 2023 23:51
Closing for now as we don't know if we will implement the challenge system inside communities to keep it simple. If anything we can re-open this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #294