-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payments] - Add Disputes and Request Payment functionalities (with Polkadot-SDK Virto fork) #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olanod
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made cosmetic changes to reduce nesting, cloning, branching and some naming updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the initial implementation of the task Pallet payments refactor.
Particularly, this is adding:
Phase 2: Request payment
B agrees to sell a product to A, and B sends an "invoice" that needs to be pay by A (no balance held)
A accept the request by calling accept_and_pay.
Calls:
request_payment
accept_and_pay
Phase 4: Disputes
Phase 4: Disputes
Disputes over a discrepancy over a payment. A buys from B, so B start the dispute.
Agreement in the refund
request_refund
.Not agreement path
request_refund
.dispute_refund
.resolve_payment
.Judge can be dynamic by implementing
DisputeResolver
trait.Disclaimer: This PR is lacking some important tasks that will be added in future PRs such as:
Set benchmarking for all pallet-payments #306
Optimization. #307
Add inline doc. #308
Configure pallet-payments in the Kreivo Runtime. #309