Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "loadPriority" property to entities. #1672

Closed
digisomni opened this issue Jun 27, 2022 · 7 comments
Closed

Add "loadPriority" property to entities. #1672

digisomni opened this issue Jun 27, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request Severity: High Important functionality is affected, no workaround exists

Comments

@digisomni
Copy link
Member

digisomni commented Jun 27, 2022

This property is a number from 1-255 (or whatever a good max integer is for the packet). This property is utilized by a client to determine which asset should be downloaded and loaded first.

Note: later we will want to add an LOD and/or renderPriority property to determine which entities should be rendered first and at what detail over other entities.

@digisomni digisomni added enhancement New feature or request Severity: High Important functionality is affected, no workaround exists labels Jun 27, 2022
@AleziaKurdis
Copy link
Contributor

"loadPriority", this is a good idea.

@daleglass
Copy link
Contributor

It's an interesting idea, but how is this supposed to be used? How does it interact with the avatar's position? And does it really need a bunch of priority levels?

There also used to be a loading screen, it could be an alternative.

@AleziaKurdis
Copy link
Contributor

This only indicates which entities need to be started to load at first. (Nothing related to the avatar position)
For example, your could set priority 1 to the model that is mainly used as the floor for a scene.
(Of course you need to keep optimal your models, like keeping the texture non embedded to accelerate the availability of the geometry where you will stand on)
The loading screen is not working fine in my opinion. Waiting long while the essential of a scene would be already there this is poor... Like the Hub that would takes an eternity to fully load... or the Overte hub that has that bridge that take 2 minutes to load while everthing else is all loaded.

Possible also that if this is built optimal, that such a priority is overkill. If there is any performance cost, I would not go ahead with it.

@daleglass
Copy link
Contributor

I mean, what you want to load first might depend on where you are. Prioritizing the floor makes sense to me, but I'm not sure if having a large number of priorities will be very useful. I think just a single "priority bit" might do the trick.

@AleziaKurdis
Copy link
Contributor

We have already many things to help optimization. I wonder if people simply use them or if those are not just too advanced for most of the users. Before add another one, maybe we can start by just explaining those tricks.
If we don't have this documented, newbe might takes a lot of time before figure those good practices.

@digisomni
Copy link
Member Author

A list of priorities is needed similar to z-index so that complex worlds can be layered appropriately. A simple toggle would mean that it's impossible to prioritize a scene with more than a handful of items as everything becomes either "important" and "unimportant".

@digisomni
Copy link
Member Author

Closed in favor of #1709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Severity: High Important functionality is affected, no workaround exists
Projects
None yet
Development

No branches or pull requests

4 participants