Add backwards compatibility for old names of OpenSSL functions #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the webrtc binary link correctly on systems using OpenSSL 3
daleglass
added a commit
to vircadia/vircadia-builder
that referenced
this pull request
May 2, 2022
This needs PR vircadia/vircadia-native-core#1650 to work.
|
How is this file linked.. it's added with no other changes to code to incorporate it... how do I test this? |
|
Test building master and this PR on Ubuntu 22.04, or Fedora 36. master should fail to build, and this PR should build correctly. |
|
Confirmed the errors stopping the build on Ubuntu 22.04. The PR fixes the errors and it builds as expected. |
|
The following links are available: |
|
Tested non-SSL WebRTC connection on Windows:
Needs testing on:
|
|
To make testing simpler, the reviewer for this on Linux should test #1540 first, have that merged, then this should be updated from master. |
ctrlaltdavid
approved these changes
May 5, 2022
ctrlaltdavid
added
CR Approved
|
The suggested route has been to combine 1540 with this PR and we'll just merge them together after testing them in tandem. |
|
I tried testing this a while back with a local ubuntu 22.04 vm, certificate generated using #1540 and it didn't seem to work properly, though I'm not sure if it's not just my weird setup. Logs from domain server when trying to connect with Web SDK example. |
digisomni
added
needs changes
and removed
CR Approved
|
Tested on an actual server with similar results, can't connect with the web sdk example, it just keeps retrying. |
|
Hello! Is this still an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the webrtc binary link correctly on systems using OpenSSL 3.
The issue here is that we have a prebuild webrtc library. By default it uses BoringSSL, but BoringSSL uses the same function names as OpenSSL and creates linking problems when linking it into a program that uses OpenSSL. So that doesn't work for us.
So we must build WebRTC against OpenSSL, but in 3.0 they renamed some functions. This means that at linking time, the functions aren't found if we build against OpenSSL 1.1 and run against OpenSSL 3.0. The actual functions we use should be compatible, the names are just different.
The OpenSSL 3.0 headers just #define old names to the new ones, but of course that doesn't do anything for binaries that reference the old names.
This patch creates wrapper functions to solve this issue.
Testing:
This needs testing on Linux, on a distribution with OpenSSL 3.0 or later, such as the Fedora 36 beta.
Fixes #1646