Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored Authentication/Google API Token #115

Open
cmhamm opened this issue Aug 22, 2016 · 3 comments
Open

Stored Authentication/Google API Token #115

cmhamm opened this issue Aug 22, 2016 · 3 comments

Comments

@cmhamm
Copy link

cmhamm commented Aug 22, 2016

Excellent job on this application. I appreciate the time and effort spent on this, and the UI is very nice.

I use the Google API to authenticate, and it would be great if you could store the API key, rather than the username and password in clear text. It would also give users a little more security, as you can generate a token request without having the user actually give a username/password. There are other stat managers that do exactly this, although none of them have the polished UI of PokeNurse.

Thanks again.

@mackhankins
Copy link
Collaborator

@cmhamm we currently use pogobuf for authentication which doesn't support token based authoriziation, but does support App Password.

@vinnymac vinnymac added this to the Future milestone Aug 22, 2016
@vinnymac
Copy link
Owner

vinnymac commented Aug 22, 2016

@cmhamm yea I agree with you that the plain text password is not ideal. We will keep track of this and try to come up with a solution eventually. Hopefully pogobuf will update and we will be able to get rid of the accounts.json we currently rely on for remembering the credentials. The user still has the option of not storing any information, which is probably the most secure option right now, however it is inconvenient.

I think pogobuf has some plans on improving its authentication methods in 2.0, so maybe we will see the possibility of this come from those changes. https://github.com/cyraxx/pogobuf/issues/8

@cmhamm
Copy link
Author

cmhamm commented Aug 22, 2016

Understood. I appreciate the consideration, and will keep an eye out. I would offer to help, but I'm a network engineer. I couldn't code my way out of a wet paper bag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants