Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Settings don't work #3

Open
BennHi opened this issue May 9, 2022 · 1 comment
Open

Browser Settings don't work #3

BennHi opened this issue May 9, 2022 · 1 comment

Comments

@BennHi
Copy link

BennHi commented May 9, 2022

Thank you for this amazing addon. After I followed the installation instructions as described, the preinstalled packets work flawlessly so far.

But when wanting to add my own packet, I found the toolbar menu not working properly in the Browser.
Whatever menu-option I click (picture 1) it always only shows "back" (picture 2). "New packet" is not clickable as well.

picture 1:
picture 1

picture 2:
picture 2

Is there something I can do about it?
Is there also another way to add packets?

@viktorstrate
Copy link
Owner

Hi @BennHi, thank you for your interest in the project.
I mostly made the project for fun as a "proof of concept" and never got around to actually add proper script management or polishing it. And now where Apple is moving away from touch bars, I'm not sure that I will ever be finishing it (although I'll keep accepting pull-requests).

As it stands currently the way to add custom scripts is to build the extension and load it manually.
Simply add a new touchbar-packet file and add it to the list here:

export const touchbarPackets = [
require('./touchbar-packets/youtube.touchbar-packet'),
require('./touchbar-packets/github.touchbar-packet'),
require('./touchbar-packets/google.touchbar-packet'),
require('./touchbar-packets/facebook.touchbar-packet'),
].map(parseTouchbarPacket)


Please beware that the helper extension has a memory leak that might cause it to take up a lot of memory over time if you have your browser open for a long period of time (see #1). You can check if this is a problem by searching for touchbar-browser-helper in ActivityMonitor.
This isn't dangerous and you can simply kill it from ActivityMonitor if it becomes a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants