Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for status assertions #4

Open
tarreislam opened this issue Nov 14, 2019 · 0 comments
Open

Suggestion for status assertions #4

tarreislam opened this issue Nov 14, 2019 · 0 comments

Comments

@tarreislam
Copy link

Hi

For assertStatus it would be more clean if the consts of Illuminate\Http\Response were used instead of integers.

Example

$response->assertStatus(200); -> $response->assertStatus(Response::HTTP_OK);
$response->assertStatus(400); -> $response->assertStatus(Response::HTTP_NOT_FOUND);
$response->assertStatus(422); -> $response->assertStatus(Response::HTTP_UNPROCESSABLE_ENTITY);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant