Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Doc Prop/Store Refactor #23

Open
ekfuhrmann opened this issue Dec 1, 2023 · 0 comments
Open

[Enhancement] Doc Prop/Store Refactor #23

ekfuhrmann opened this issue Dec 1, 2023 · 0 comments

Comments

@ekfuhrmann
Copy link
Contributor

In #22 we introduced a new way of labeling specific items as doc items, enforcing full screen viewport and disabling the ability to resize the iframe. This is done through passing props down through numerous components. It seems like it would make more sense to add this to the Store, but we're a bit unclear on a good way of handling that.

The refactor should look at the following comments for context:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant