Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5.8] API change / BC break #537

Open
remicollet opened this issue Nov 12, 2024 · 1 comment
Open

[1.5.8] API change / BC break #537

remicollet opened this issue Nov 12, 2024 · 1 comment

Comments

@remicollet
Copy link
Contributor

I noticed 2 major API changes in 1.5.8

         Method [ <internal:xlswriter> public method setColumn ] {
 
-          - Parameters [3] {
-            Parameter #0 [ <required> $format_handle ]
-            Parameter #1 [ <required> $range ]
-            Parameter #2 [ <required> $width ]
+          - Parameters [6] {
+            Parameter #0 [ <required> $range ]
+            Parameter #1 [ <required> $width ]
+            Parameter #2 [ <optional> $format_handle = <default> ]
+            Parameter #3 [ <optional> $level = <default> ]
+            Parameter #4 [ <optional> $collapsed = <default> ]
+            Parameter #5 [ <optional> $hidden = <default> ]
           }
         }
 
         Method [ <internal:xlswriter> public method setRow ] {
 
-          - Parameters [3] {
-            Parameter #0 [ <required> $format_handle ]
-            Parameter #1 [ <required> $range ]
-            Parameter #2 [ <required> $height ]
+          - Parameters [6] {
+            Parameter #0 [ <required> $range ]
+            Parameter #1 [ <required> $height ]
+            Parameter #2 [ <optional> $format_handle = <default> ]
+            Parameter #3 [ <optional> $level = <default> ]
+            Parameter #4 [ <optional> $collapsed = <default> ]
+            Parameter #5 [ <optional> $hidden = <default> ]
           }
         }

Not even documented in changelog.

New parameter order will break old code written with version <= 1.5.7

@remicollet remicollet changed the title API change / BC break [1.5.8] API change / BC break Nov 12, 2024
@remicollet
Copy link
Contributor Author

Looking at change in 1aa4bf6 only ARGINGO were changed
Function parameter order is the same,
so this seems to be only a bugfix fixing the arginfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant