Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent Deprecation Warning on Video.js 8 #623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

funkymonk91
Copy link

Resolves: VIDEOJS: WARN: videojs.createTimeRange is deprecated and will be removed in 9.0; please use videojs.time.createTimeRanges instead.

@mister-ben
Copy link

Thanks. The tech still works with v7 of video.js, so to avoid making this a breaking change, this should fallback to videojs.createTimeRange when videojs.time.createTimeRanges is not available.

@mister-ben mister-ben changed the title Fix Deprecation Warning fix: Prevent Deprecation Warning on Video.js 8 Jun 11, 2024
@gkatsev
Copy link
Member

gkatsev commented Jun 11, 2024

@gkatsev
Copy link
Member

gkatsev commented Jun 11, 2024

Ignore me, @mister-ben is correct. Needs a fallback for v7 as it doesn't have .time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants