Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter Twee output for required and optional StoryData properties #452

Closed
2 tasks done
videlais opened this issue Jan 17, 2024 · 0 comments · Fixed by #453
Closed
2 tasks done

Stricter Twee output for required and optional StoryData properties #452

videlais opened this issue Jan 17, 2024 · 0 comments · Fixed by #453
Assignees
@videlais
Labels
enhancement New feature or request
Milestone
Extwee 2.2.2

Comments

@videlais
Copy link
Owner

videlais commented Jan 17, 2024 •
edited
Loading

The ifid is the only required property of the StoryData passage.

The use of Story.toTwee() should:

  • Detect if internal IFID is not in UUIDv4 format, generate a warning, and create a new IFID.
  • Avoid generating format, format-version, start, tag-colors, or zoom unless those properties have non-default values.
@videlais videlais added the enhancement New feature or request label Jan 17, 2024
@videlais videlais added this to the Extwee 2.2.2 milestone Jan 17, 2024
@videlais videlais self-assigned this Jan 17, 2024
@videlais videlais linked a pull request Jan 18, 2024 that will close this issue
Adding more tests for optional and required values #453
Merged
@videlais videlais mentioned this issue Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@videlais videlais

Labels
enhancement New feature or request
Projects
None yet
Milestone
Extwee 2.2.2
Development

Successfully merging a pull request may close this issue.

Adding more tests for optional and required values videlais/extwee
1 participant
@videlais