Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a user doesn't have location permissions enabled on their browser, the map pin icon button doesn't do anything. #2

Closed
victorgaard opened this issue Mar 31, 2022 · 2 comments

Comments

@victorgaard
Copy link
Owner

victorgaard commented Mar 31, 2022

(Submitted by Matt)

Current behavior: if a user doesn't allow location permissions when they first click the map pin button, the UI doesn't give any feedback, staying as a usable button, even though it won't do anything.
image

Desired behavior: if a user doesn't allow location permissions, the UI should give feedback and change the button state for further interactions.

@victorgaard
Copy link
Owner Author

Solution proposed: if a user click the map pin button and doesn't allow location permissions, the button changes to red with a crossed map icon, and a tooltip under it. The tooltip reappears on hover for desktop interactions and on tap for mobile interactions.

Button is still clickable, so if the user changes the location settings and click it, it will work just fine.

image

@victorgaard
Copy link
Owner Author

There there, now it's closed! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant