Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I build this (using e.g. npm run build)? #44

Open
ApproximateIdentity opened this issue Jan 7, 2021 · 3 comments
Open

How do I build this (using e.g. npm run build)? #44

ApproximateIdentity opened this issue Jan 7, 2021 · 3 comments

Comments

@ApproximateIdentity
Copy link

I tried installing a fresh node environment:

twn$ nodeenv --prebuilt nodeenv
 * Install node (15.5.1)... done.
twn$ source nodeenv/bin/activate
(nodeenv)twn$ npm install

added 380 packages, and audited 381 packages in 4s

4 vulnerabilities (3 low, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
(nodeenv)twn$ npm install --global

added 1 package, and audited 3 packages in 472ms

found 0 vulnerabilities

Then I tried to run build:

(nodeenv)twn$ npm run build

> [email protected] build
> rollup -c

sh: 1: rollup: not found
npm ERR! code 127
npm ERR! path /home/twn/repos/github.com/victordibia/handtrack.js
npm ERR! command failed
npm ERR! command sh -c rollup -c

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/twn/.npm/_logs/2021-01-07T20_53_32_648Z-debug.log

Okay so I tried installing rollup:

(nodeenv)twn$ npm install rollup
npm WARN deprecated [email protected]: "Please update to latest v2.3 or v2.2"

added 2 packages, and audited 383 packages in 1s

4 vulnerabilities (3 low, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
(nodeenv)twn$ npm install --global rollup
npm WARN deprecated [email protected]: "Please update to latest v2.3 or v2.2"

added 2 packages, and audited 3 packages in 509ms

found 0 vulnerabilities

Then I tried running build again:

(nodeenv)twn$ npm run build

> [email protected] build
> rollup -c


src/index.js → dist/handtrack.min.js, demo/handtrack.min.js...
(!) Use of eval is strongly discouraged
https://rollupjs.org/guide/en/#avoiding-eval
node_modules/@tensorflow/tfjs-converter/dist/tf-converter.esm.js
15:  * =============================================================================

    [ ... removed ... ]

18: //# sourceMappingURL=tf-converter.esm.js.map
[!] (plugin babel-minify) TypeError: Banner must be a valid comment.
TypeError: Banner must be a valid comment.
    at PluginPass.Program (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@comandeer/babel-plugin-banner/dist/babel-plugin-banner.js:2:476)
    at newFn (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/visitors.js:193:21)
    at NodePath._call (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/path/context.js:53:20)
    at NodePath.call (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/path/context.js:40:17)
    at NodePath.visit (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/path/context.js:88:12)
    at TraversalContext.visitQueue (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/context.js:118:16)
    at TraversalContext.visitSingle (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/context.js:90:19)
    at TraversalContext.visit (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/context.js:146:19)
    at Function.traverse.node (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/index.js:94:17)
    at traverse (/home/twn/repos/github.com/victordibia/handtrack.js/node_modules/@babel/traverse/lib/index.js:76:12)

npm ERR! code 1
npm ERR! path /home/twn/repos/github.com/victordibia/handtrack.js
npm ERR! command failed
npm ERR! command sh -c rollup -c

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/twn/.npm/_logs/2021-01-07T20_53_59_766Z-debug.log

What am I missing here? I'm sure this is something basic and obvious for those a bit more experienced with node, but I'm a little lost. By the way, I'm running

  • Debian 10
  • node version 15.5.1 (as seen above)
  • npm version 7.3.0

Thanks for any help! And thanks for the super interesting project!

@victordibia
Copy link
Owner

Its been a while since I worked on this, don't have any immediate feedback.
Back then, I used rollup.js for bundling up the model .

@oGsLP
Copy link

oGsLP commented Feb 26, 2021

the same question

@oGsLP
Copy link

oGsLP commented Feb 26, 2021

Got it, little modification in rollup.config.js should work
Use rollup-plugin-terser instead of rollup-plugin-babel-minify as the latter one is archived, maybe something incompatible. And this will fix the wtf Banner problem.
By the way, rollup-plugin-node-resolve is archived too, better change to @rollup/plugin-node-resolve.

the final code is like this:

// import minify from 'rollup-plugin-babel-minify';
// import resolve from 'rollup-plugin-node-resolve';
import {nodeResolve} from '@rollup/plugin-node-resolve';
import {terser} from 'rollup-plugin-terser';

// ..

plugins: [nodeResolve(), terser()]

@victordibia @ApproximateIdentity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants