Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch-luks-suspend assumes that the root device is /dev/mapper/{crypt-name} #8

Open
afn opened this issue Dec 30, 2016 · 0 comments
Open

Comments

@afn
Copy link

afn commented Dec 30, 2016

I use LVM on my system, so my crypt device is /dev/mapper/vgcrypt and the root filesystem is actually mounted on /dev/mapper/vgcrypt-root. Here's my /proc/cmdline:

initrd=\initramfs-linux.img cryptdevice=/dev/sda4:vgcrypt:allow-discards acpi_backlight=vendor nouveau.nofbaccel=1 root=/dev/mapper/vgcrypt-root rw

The arch-luks-suspend script temporarily remounts ext4 filesystems with barrier=0, but it looks for a mounted filesystem in /dev/mapper/${CRYPTNAME}, which isn't necessarily the root filesystem's device. Instead, I think it should use the value of root in /proc/cmdline. I'll submit a PR shortly.

afn added a commit to afn/arch-luks-suspend that referenced this issue Dec 30, 2016
guns added a commit to guns/go-luks-suspend that referenced this issue Aug 22, 2017
cf. #1

In an LVM on LUKS setup the root cryptdevice does not hold the
filesystem that is mounted on /. We can get this information from
/proc/cmdline instead.

Credit to afn:

vianney#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant