Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tackle limitation of point coordinate system #125

Open
akoch-yatta opened this issue Oct 7, 2024 · 2 comments · May be fixed by eclipse-platform/eclipse.platform.swt#1524
Open

Tackle limitation of point coordinate system #125

akoch-yatta opened this issue Oct 7, 2024 · 2 comments · May be fixed by eclipse-platform/eclipse.platform.swt#1524
Assignees
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone

Comments

@akoch-yatta
Copy link

akoch-yatta commented Oct 7, 2024

There are some scenarios, e.g. with detached views in the IDE, where point to pixels conversion lead to unexpected results e.g. in something like this:

Point p = display.getCursorLocation();
p.x -= 100;
shell.setLocation(p);

If p.x -= 100; will lead to the point being placed on another monitor with different zoom, this can lead to a unexpected positioning of the shell.

Two ideas to evaluate:
1.) extend point and rectangle with a zoom attribute

2.) Create DisplayPoint and DisplayRectangle only for win32 as subclasses and use them in scenarios where a display related pixel to point conversion happen

@akoch-yatta akoch-yatta converted this from a draft issue Oct 7, 2024
@akoch-yatta akoch-yatta added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature Enhancement A Request for an Enhancement of an Existing Feature labels Oct 7, 2024
@amartya4256 amartya4256 self-assigned this Oct 7, 2024
@akoch-yatta
Copy link
Author

Improved by PR #1524

@akoch-yatta
Copy link
Author

As discussed in the daily, we will rediscuss this issue and possible solutions

@akoch-yatta akoch-yatta modified the milestones: 4.34 M3, 4.35 M1 Nov 6, 2024
@akoch-yatta akoch-yatta moved this from 👀 In Review to Blocked in Eclipse Nov 6, 2024
@akoch-yatta akoch-yatta moved this from Blocked to 🏗 In Work: Short in Eclipse Dec 2, 2024
@akoch-yatta akoch-yatta self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: 🏗 In Work: Short
Development

Successfully merging a pull request may close this issue.

3 participants