-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WDL requires Docker images on dockerhub #1
Comments
Dang, yeah, I don't see any blocker to creating a vgteam docker hub account and pushing the image there too. Quay has a much nicer web UI for perusing the available images but if we push to both from CI then I don't see much risk from having the mirror. @adamnovak @glennhickey any comments? |
Pushing to both, or even switching from Quay to Dockerhub, is fine with
me!
…On Wed, Jan 30, 2019 at 2:02 PM Mike Lin ***@***.***> wrote:
Dang, yeah, I don't see any blocker to creating a vgteam docker hub
account and pushing the image there too. Quay has a much nicer web UI for
perusing the available images but if we push to both from CI then I don't
see much risk from having the mirror. @adamnovak
<https://github.com/adamnovak> @glennhickey
<https://github.com/glennhickey> any comments?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA2_7uBE3qmP0W5MAx_C9j2JEtewVVhKks5vIexXgaJpZM4aav8B>
.
|
I've worked Quay into the VG CI system, and I'm lazy and don't want to
rip it out.
There's no problem I can see mirroring to Docker Hub though, besides
user confusion over which is canonical if they ever go out of sync.
…On 1/30/19, Glenn Hickey ***@***.***> wrote:
Pushing to both, or even switching from Quay to Dockerhub, is fine with
me!
On Wed, Jan 30, 2019 at 2:02 PM Mike Lin ***@***.***> wrote:
> Dang, yeah, I don't see any blocker to creating a vgteam docker hub
> account and pushing the image there too. Quay has a much nicer web UI
> for
> perusing the available images but if we push to both from CI then I
> don't
> see much risk from having the mirror. @adamnovak
> <https://github.com/adamnovak> @glennhickey
> <https://github.com/glennhickey> any comments?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>, or
> mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AA2_7uBE3qmP0W5MAx_C9j2JEtewVVhKks5vIexXgaJpZM4aav8B>
> .
>
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1 (comment)
|
Sadness: the "vgteam" docker hub namespace is taken by an esports company... |
: ( I own "variantgraphs," and naturally it belongs to the one true vgteam. |
I'm happy to use that. I'm dnamlin on docker hub, can you add me and i'll see what the credentials situation is? |
Just added you to the org - sorry for the delay! |
Docker Hub doesn't seem to have the feature of limited API/robot keys, so to avoid having vgteam/vg_docker login in the guise of one of us personally (with full access to our other, unrelated repositories on docker hub), we will have to create a dedicated Docker Hub account for that purpose |
Alright, we should now be set so that whenever @adamnovak cuts a point release of vg, the image will be mirrored to docker hub as well. vgteam/vg_docker#9 |
WDL (at least as currently in FireCloud) requires Docker images to be pulled from Dockerhub; Quay and other repositories are not supported.
@mlin would it be possible to tweak the build.sh script in vg_docker to do a:
at the end of the build.sh script?
The text was updated successfully, but these errors were encountered: