Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of internal Vert.x EventLoopGroup #60

Open
meshuga opened this issue Dec 17, 2015 · 2 comments
Open

Make use of internal Vert.x EventLoopGroup #60

meshuga opened this issue Dec 17, 2015 · 2 comments

Comments

@meshuga
Copy link
Contributor

meshuga commented Dec 17, 2015

Mongo client can make use of Netty event loop group for async request processing, so it might be possible to pass a vert.x group instance using io.vertx.core.Vertx#nettyEventLoopGroup() to https://github.com/mongodb/mongo-java-driver/blob/master/driver-async/src/main/com/mongodb/async/client/MongoClientSettings.java#L272 like below:

builder.streamFactoryFactory(
  new NettyStreamFactoryFactory(vertx.nettyEventLoopGroup(), ByteBufAllocator.DEFAULT))
  .build();

According to http://normanmaurer.me/presentations/2014-facebook-eng-netty/slides.html#25.0 it's a good idea 😉

@karianna karianna added this to the Backlog milestone Dec 17, 2015
@karianna
Copy link
Contributor

@johnoliver going to have to defer to your wisdom here. Good idea or no?

@llfbandit
Copy link
Contributor

Seems a good idea to me (with all my noobishness knowledge in vertx 🎱 ), the job has been already done in other sections by the way to be more concrete.
This commit is a partial view of some of the places where we can find the attachement to the netty looper : eclipse-vertx/vert.x@a595010

@vietj vietj modified the milestones: Backlog, 4.0.0 Nov 29, 2018
@karianna karianna removed this from the 4.0.0 milestone May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants