Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump guava from 30.1.1-jre to 32.1.2-jre #150

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

vietj
Copy link
Contributor

@vietj vietj commented Oct 6, 2023

This fixes insecure permissions of files created in the temporary directory: https://nvd.nist.gov/vuln/detail/CVE-2023-2976

Version 32 is binary compatible with version 30 because only the GWT jar has breaking changes:
google/guava#2575 (comment)

I run CI for these repositories and found no regressions:

The failures in vertx-zookeeper are not regressions because they exist with 30.1.1-jre.

I found no other Vert.x repository that uses Guava and hasn't been removed for Vert.x 5.

This fixes insecure permissions of files created in the temporary
directory: https://nvd.nist.gov/vuln/detail/CVE-2023-2976

Version 32 is binary compatible with version 30 because only the
GWT jar has breaking changes:
google/guava#2575 (comment)

I run CI for these repositories and found no regressions:

* vertx-config: https://github.com/julianladisch/vertx-config/actions/runs/6289869333
* vertx-grpc: https://github.com/julianladisch/vertx-grpc/actions/runs/6289478128
* vertx-zookeeper: https://github.com/julianladisch/vertx-zookeeper/actions/workflows/ci-5.x.yml

The failures in vertx-zookeeper are not regressions because they
exist with 30.1.1-jre.

I found no other Vert.x repository that uses Guava and hasn't
been removed for Vert.x 5.

Obsoletes #118
@vietj vietj added this to the 4.4.6 milestone Oct 6, 2023
@vietj vietj merged commit c52bdfa into 4.4 Oct 6, 2023
1 check passed
@vietj vietj deleted the guava-32.1.2-jre-upgrade-4.4 branch October 6, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants