Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: some of the packages are not changing accordingly #337

Open
padulkemid opened this issue Aug 7, 2024 · 7 comments
Open

[BUG]: some of the packages are not changing accordingly #337

padulkemid opened this issue Aug 7, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@padulkemid
Copy link

Version
0.5.4
OS
macOS

Describe the bug
Won't change version, always fallback to machine's env like java to usr/bin/java and nodejs to usr/local/bin/node.

Is there anything wrong with my setup? since I just brew update && brew upgrade everything yesterday? (might be an issue with some packages that always falling back to default version?)

Screenshots[optional]
image

@padulkemid padulkemid added the bug Something isn't working label Aug 7, 2024
@padulkemid
Copy link
Author

confirmed: work with kotlin and golang, just java and nodejs

@padulkemid
Copy link
Author

image

it appears vfox 's dir in $PATH are added in below from the bin, should we move it to the topmost path?

@padulkemid
Copy link
Author

I think this commit is from months ago and the version before works fine, is this PATH changing state are handled in here?

pathSet := env.NewPaths(env.EmptyPaths)
  for _, item := range items {
  	if item.Key == "PATH" {
		pathSet.Add(item.Value)
	} else {
		envKeys.Variables[item.Key] = &item.Value
	}
  }

envKeys.Paths = pathSet

@kuddl
Copy link

kuddl commented Oct 29, 2024

I have the same issue...
But only in my VS Code Terminal .. I use Warp for my main standalone Terminal, and everything works fine there.. any solution to this? @padulkemid maybe you solved it?

@padulkemid
Copy link
Author

I have the same issue... But only in my VS Code Terminal .. I use Warp for my main standalone Terminal, and everything works fine there.. any solution to this? @padulkemid maybe you solved it?

i think its about the pathing source and stuff (it might be, from the PATH commit earlier) I haven't take a look at it, since it causes my workflow to be broken,so I moved into mise now @kuddl

@kuddl
Copy link

kuddl commented Oct 30, 2024

I "kind of fixed it", but do not know why it worked:

Even though the VSCode terminal said: echo $SHELL -> /bin/zsh
vfox was not poperly activated ...
I added the bash activate (!) command to my .zshrc, and then it work as expected.

So I have both commands in my .zshrc

# vfox
eval "$(vfox activate zsh)"
eval "$(vfox activate bash)"

I suspect, that something is missing in the zsh variant, that VSCode needs or looks for ...

But for now it works.
To @aooohan: Thanks a lot for the project! Maybe this hint / bug is helpful.

@padulkemid
Copy link
Author

by taking a look at the code, there are subtle differences between activating the shell in zsh and bash, 2 of this has the same commands but there are some quirks that made the same commands achieve different result, might something to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants