Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magithub-browse-file-blame #378

Open
stardiviner opened this issue Sep 25, 2018 · 4 comments
Open

magithub-browse-file-blame #378

stardiviner opened this issue Sep 25, 2018 · 4 comments

Comments

@stardiviner
Copy link
Contributor

This is a new continue of issue #377 (comment)
The command magithub-browse-file-blame opened URL with wrong commit hash.
@vermiculus
Copy link
Owner

That function uses the full hash of HEAD for the URL. What is that hash? git rev-parse HEAD

@stardiviner
Copy link
Contributor Author

It is f92a80c18ddc7faae5ed30c76cad47bd4551607f result from git rev-parse HEAD.

@stardiviner
Copy link
Contributor Author

I will take a look at github-browse-file-blame tomorrow.

@stardiviner
Copy link
Contributor Author

I checked out github-browse-file-blame. Have not found any obviously different with magithub-browse-file-blame. magithub-browse-file-blame use git re-parse HEAD. But github-browse-blame seems does not use that. I can't find where it get the commit hash. weird. I checked function github-browse-file--browse-url, not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stardiviner @vermiculus