Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting is not applied #354

Open
vspinu opened this issue Jul 30, 2018 · 2 comments
Open

Sorting is not applied #354

vspinu opened this issue Jul 30, 2018 · 2 comments
Labels
bug describes a defect in supported/advertised functionality unconfirmed has not been reproduced by a maintainer

Comments

@vspinu
Copy link

vspinu commented Jul 30, 2018

AFAICS magithub-issue--sort is never called.

I have

(defun my-magithub-issue-sort-updated-ascending (a b)
  (time-less-p (date-to-time (alist-get 'updated_at a))
               (date-to-time (alist-get 'updated_at b))))

(setq magithub-issue-sort-function #'my-magithub-issue-sort-updated-ascending)

BTW, would be nice to have such a sort function as part of magithub itself. It's a common pattern. Even better, would be great to have toggling of the sorting type inside the status buffer. Would you like to have a separate issue for that?

@vermiculus
Copy link
Owner

Regarding default sorts, there's an issue for that already. I'd like to realize some concept of issue 'views' that can be switched between, but sadly I've not had the time for this project as I once did.

@vspinu
Copy link
Author

vspinu commented Jul 31, 2018

Here it is #124. Would be great indeed!

@vermiculus vermiculus added bug describes a defect in supported/advertised functionality unconfirmed has not been reproduced by a maintainer labels Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug describes a defect in supported/advertised functionality unconfirmed has not been reproduced by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants