fix(all): Small things

verklegarden · Nov 2, 2023 · c96aff4 · c96aff4
1 parent bae2027
commit c96aff4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/src/signatures/ECDSA.sol b/src/signatures/ECDSA.sol
@@ -185,6 +185,7 @@ library ECDSA {
     ///      - Private key invalid
     ///
     /// @custom:vm vm.sign(uint,bytes32)
+    /// @custom:invariant Returned signature is non-malleable.
     function sign(PrivateKey privKey, bytes memory message)
         internal
         view
@@ -203,6 +204,7 @@ library ECDSA {
     ///      - Private key invalid
     ///
     /// @custom:vm vm.sign(uint,bytes32)
+    /// @custom:invariant Returned signature is non-malleable.
     function sign(PrivateKey privKey, bytes32 digest)
         internal
         view
@@ -227,6 +229,7 @@ library ECDSA {
     }
 
     // @todo Docs signEthereumSignedMessage
+    /// @custom:invariant Returned signature is non-malleable.
     function signEthereumSignedMessage(PrivateKey privKey, bytes memory message)
         internal
         view
@@ -239,6 +242,7 @@ library ECDSA {
     }
 
     // @todo Docs signEthereumSignedMessageHash
+    /// @custom:invariant Returned signature is non-malleable.
     function signEthereumSignedMessageHash(PrivateKey privKey, bytes32 digest)
         internal
         view

diff --git a/test/curves/secp256k1/Secp256k1Arithmetic.t.sol b/test/curves/secp256k1/Secp256k1Arithmetic.t.sol
@@ -123,6 +123,8 @@ contract Secp256k1ArithmeticTest is Test {
     //--------------------------------------------------------------------------
     // Test: Utils
 
+    // -- modularInverseOf
+
     function testFuzz_modularInverseOf(uint x) public {
         vm.assume(x != 0);
         vm.assume(x < Secp256k1Arithmetic.P);

diff --git a/test/signatures/ECDSA.t.sol b/test/signatures/ECDSA.t.sol
@@ -169,6 +169,8 @@ contract ECDSATest is Test {
         wrapper.sign(privKey, keccak256(message));
     }
 
+    // @todo Test property: Signature is non-malleable.
+
     // @todo Test signEthereum...
 
     //--------------------------------------------------------------------------