Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: URL hardcoding #9

Open
mboyas-mitre opened this issue Jan 16, 2019 · 2 comments
Open

Enhancement: URL hardcoding #9

mboyas-mitre opened this issue Jan 16, 2019 · 2 comments

Comments

@mboyas-mitre
Copy link
Contributor

stop("Error: need training data for PHMRC data, possible training data could be obtained at http://ghdx.healthdata.org/record/population-health-metrics-research-consortium-gold-standard-verbal-autopsy-data-2005-2011")

I like this message; however, what happens if the URL goes out of date? Have you noticed movement on the GHDx website in the past? We'd suggest either just marking this down in your records as something to stay on top of, or abstracting the message to direct to the parent site and maybe including the specific url with a last checked date.

@richardli
Copy link
Collaborator

It should be permanent link, but not in our hands, what would you suggest to add in this code?

@mboyas-mitre
Copy link
Contributor Author

Hm, the easiest thing to do for now might be just to add to the stop message something like "This link is current as of XX date" just so it's clear to the end user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants