Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Individual plotting functions #24

Open
mboyas-mitre opened this issue Feb 19, 2019 · 0 comments
Open

Enhancement: Individual plotting functions #24

mboyas-mitre opened this issue Feb 19, 2019 · 0 comments

Comments

@mboyas-mitre
Copy link
Contributor

openVA/openVA/R/stackplot.r

Lines 131 to 140 in f16a333

return(stackplot(x, grouping = grouping,
type = type,
order.group = order.group, order.sub = order.sub,
err = err, CI = CI, sample.size.print = sample.size.print,
xlab = xlab, ylab = ylab, ylim = ylim,
title = title,
horiz = horiz, angle = angle,
err_width = err_width, err_size = err_size,
point_size = point_size,
border = border, bw = bw, ...))

insilico has its own plotting code that significantly simplifies this stackplot wrapper. We would recommend adding parallel codes to the individual InterVA, Tariff, etc. functions that parallel this, and then this stackplotVA function can become a true wrapper and call the individual functions. Doing so would (1) enable a user of one of the individual packages (but not openVA) to create the plots and (2) simplify the code housed in openVA for maintainability and readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant