-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(elasticsearch-plugin): Update ElasticSearch supported version from v7.9.1 to v8.13.1 #3121
Open
LeftoversTodayAppAdmin
wants to merge
115
commits into
vendure-ecommerce:major
Choose a base branch
from
LeftoversTodayAppAdmin:chore-elasticsearch-plugin-update-to-v8.13.1
base: major
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommerce#2961) Remove a workaround that led to refetching relations in customFields. Prevent refetching of customFields during hydration
This is now set to the default setting in GitHub, which means the config file is not needed and maintenance will be easier.
Fixes vendure-ecommerce#2097. This commit alters the way we store the RequestContext object on the `req` object so that we can better target individual handlers, preventing parallel execution of queries from interfering with one another.
The fix f235249 inadvertently broke transactions across field resolvers in all databases apart from SQLite. This commit solves that.
This commit introduces some new low-level APIs to the data layer of the Admin UI. It allows us to control which custom fields get dynamically added to fragments when making queries & mutations. It also exposes a new method on the QueryResult class which allows us to update & refetch the underlying DocumentNode whenever the selected custom fields changes. Relates to vendure-ecommerce#3097
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ElasticSearch version greater than 7.9.1 cannot be currently used because thats what the plugin is looking for and it matches the warning in the documentation.
https://github.com/vendure-ecommerce/vendure/blob/master/packages/elasticsearch-plugin/package.json
https://docs.vendure.io/reference/core-plugins/elasticsearch-plugin/
But the issue linked in the documentation was closed a long time ago: elastic/elasticsearch-js#1519
This chore updates the documentation, plugin ES client dependency and E2E testing docker container to all use the newer matching version of ElasticSearch 8.13.1 and corresponding node package.
Breaking changes
BREAKING CHANGE: users must keep the minimum version in sync across:
Since the package.json file for the plugin is being updated to use ~8.13.1, it will not be backwards compatible with older v7 ElasticSearch deployments.
Source
Language clients are forward compatible; meaning that clients support communicating with greater or equal minor versions of Elasticsearch. Elasticsearch language clients are only backwards compatible with default distributions and without guarantees made.
Please refer to ElasticSearch documentation for upgrading your deployment without any breaks or data loss.
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: