Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order interceptor #3233

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Order interceptor #3233

merged 11 commits into from
Nov 26, 2024

Conversation

michaelbromley
Copy link
Member

Description

Implements the OrderInterceptor interface described in #2123.

Breaking changes

No, but the UpdateOrderItemsResult and RemoveOrderItemsResult union types returned by the Shop API order mutations now include the new OrderInterceptorError error result type.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 26, 2024 7:59am

Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@michaelbromley michaelbromley merged commit 7706e35 into minor Nov 26, 2024
28 of 32 checks passed
@michaelbromley michaelbromley deleted the order-interceptor branch November 26, 2024 09:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant