Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By mistake i click twice on update in collection and its added same two entries in a collection. vendure version 2 beta #2117

Open
ashishkpaul opened this issue Apr 11, 2023 · 3 comments
Assignees
Labels
P4: low Non-critical, workarounds exist type: bug 🐛 Something isn't working @vendure/admin-ui
Milestone

Comments

@ashishkpaul
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Collections'
  2. Click on 'Create New Collection'
  3. Action 'Double Click On Create Button'
  4. See error

Screenshot_2023-04-11_13-59-32

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • @vendure/core version:
  • Nodejs version
  • Database (mysql/postgres etc):

Additional context
Add any other context about the problem here.

@ashishkpaul ashishkpaul added the type: bug 🐛 Something isn't working label Apr 11, 2023
@michaelbromley
Copy link
Member

Just confirmed this is still the case with the latest v2.2.x.

@michaelbromley
Copy link
Member

This is a general issue on all the detail pages with "create" and "update" functionality - the button stays enabled when the first request is still in flight.

The simple solution is to track the state of the request with something like a requestStatus variable which is used to disable the button(s) when the status matches in-flight or whatever.

@michaelbromley michaelbromley added contributions welcome P4: low Non-critical, workarounds exist labels Jul 15, 2024
@michaelbromley michaelbromley moved this from 📋 Backlog to 📅 Planned in Vendure OS Roadmap Jul 15, 2024
@dlhck dlhck moved this from 📅 Planned to 📦 Backlog in Vendure OS Roadmap Sep 24, 2024
@dlhck dlhck moved this from 📦 Backlog to 📅 Planned in Vendure OS Roadmap Sep 24, 2024
@dlhck dlhck added this to the v3.2 milestone Sep 24, 2024
@dlhck
Copy link
Collaborator

dlhck commented Sep 24, 2024

Will be done together with #2903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4: low Non-critical, workarounds exist type: bug 🐛 Something isn't working @vendure/admin-ui
Projects
Status: 📅 Planned
Development

No branches or pull requests

3 participants