Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable anchor scrolling for angular router module #1459

Open
simpian opened this issue Mar 5, 2022 · 1 comment
Open

enable anchor scrolling for angular router module #1459

simpian opened this issue Mar 5, 2022 · 1 comment
Labels
P3: minor Non-critical, no workarounds exist status: blocked 🚧 Resolution is blocked by some other issue or external factor type: feature ✨

Comments

@simpian
Copy link
Contributor

simpian commented Mar 5, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

If I have a url fragment, I would like angular to scroll to that specific section, but this has to be turned on in angular router module.
http://localhost:3000/admin/extensions/common/test#1234
http://localhost:3000/admin/extensions/common/test#4567

https://angular.io/api/router/ExtraOptions#anchorScrolling
e.g.

@NgModule({
    declarations: [],
    imports: [
        CommonModule,
        AppComponentModule,
        RouterModule.forRoot(routes, { useHash: false, relativeLinkResolution: 'legacy', **anchorScrolling: 'enabled'** }),
    ],
    providers: [],
    bootstrap: [AppComponent],
})
export class AppModule {}

can we add this in angular?

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@michaelbromley michaelbromley moved this to 📅 Planned in Vendure OS Roadmap Jul 1, 2022
@dlhck dlhck moved this from 📅 Planned to 📦 Backlog in Vendure OS Roadmap Sep 24, 2024
@dlhck dlhck added P3: minor Non-critical, no workarounds exist type: feature ✨ labels Sep 24, 2024
@dlhck
Copy link
Collaborator

dlhck commented Sep 24, 2024

Can be done together with #2903

@dlhck dlhck modified the milestone: v3.2.0 Sep 27, 2024
@dlhck dlhck added the status: blocked 🚧 Resolution is blocked by some other issue or external factor label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3: minor Non-critical, no workarounds exist status: blocked 🚧 Resolution is blocked by some other issue or external factor type: feature ✨
Projects
None yet
Development

No branches or pull requests

2 participants