-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are there plans for implementing SSR? #10
Comments
Hello @tmpg , Thank you for interest.
|
1.Could you describe your use case please? 2.Why other SSR solution couldn't be used as separate package? |
@tmpg I meant what for you've used server rendering, what the purpose? Emails? SEO? Is there any other purpose? |
@tmpg we're using meteor-ssr |
@jborseth with code splitting in Meteor 1.5 apps is lightweight and load blazing fast. |
I'm wondering:
Questions may sound obvious, but we need to make sure we are on the same page. Thank you. |
Just to add to the conversation. We are also using FlowRouter SSR in our React + Meteor app. The primary goal was SEO. We forked the original FlowRouterSSR branch when Kadira announced it was stopping support for it: https://github.com/bensventures/flow-router (Works up to Meteor 1.5, not tested in 1.6 yet) Trying to give some answers to your questions above:
Historically FlowRouterSSR only worked with React I believe. It would of course be nice to have it working with both Blaze and React. And in a less hacky way than what it is now. I had to look at the code to get it to work with 1.5 and the SSR branch feels more like a hack with fast-render than a real SSR implementation. |
Related to #47 - add FastRender support, where is partially implemented SSR. |
SSR makes also sense for stuff like facebook crawler, which uses og-tags to read information. But unfortunatly as of october 2018, the facebook crawler still does not interpret javascript. With react, its usually pretty easy to do SSR, so i thinking about switching to react-router for that, but it would be awesome if FlowRouter would support it. I think it's not that hard with the new meteor api. |
@macrozone why you need this on router level? It's possible to implement on app-level with the new meteor api, right? Although, SSR will add tags to head it wouldn't be good for SEO due to Cloaking. You don't need to waste time and resources on implementing SSR, better use self hosted Prerendering or SaaS Prerendering solution |
@dr-dimitru of course this needs to be on the router level, because you don't want to specify all routes twice (one on server and one on client). But maybe i try to do some proof-of-concept at the weekend... I don't understand the cloaking argument. That's definitly not cloaking. Yes, prerenders work as well, but you won't get the other advantages like even faster page loads. SSR is not wasted time and resources, its the right way to go. Prerendering is just a workaround. |
one idea:
i currently stuck at finding the right route from sink.request.url. This is done with page.js on the client with some fancy regex. But i try now to find out, whether i can use the same logic on the server |
@macrozone what actually do you need to compare against |
@dr-dimitru I got it, i will open up a PR soon. |
- 📦 NPM `[email protected]` update - 🤝 Merge #58, introducing Basic SSR API, partly 🤔 covering #10, thanks to @macrozone for PR and @coagmano for assistance
Hello everyone, thank you for the patience here 🙃 Please take a look and try v3.6.1, where we merged #58 introducing Basic SSR API, thanks to @macrozone and @coagmano |
Hello @tmpg @macrozone @coagmano @tmpg @bensventures , Friendly ping on this one. What its status? Is it implemented and working properly? |
@dr-dimitru yes, it works. But i only use it in one project, which still uses FlowRouter and Meteor-collections |
Hey, guys love the repo. Especially the new 1.5 features.
Are there plans for implementing SSR?
Thanks,
TMPG
The text was updated successfully, but these errors were encountered: