Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maint: Do not pass literal json to read_json in test #3221

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Maint: Do not pass literal json to read_json in test #3221

merged 1 commit into from
Oct 9, 2023

Conversation

binste
Copy link
Contributor

@binste binste commented Oct 9, 2023

Closes #3214

jonmmease
jonmmease approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@binste binste merged commit bcae0f1 into vega:main Oct 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmmease jonmmease jonmmease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not pass literal json to read_json
2 participants
@binste @jonmmease