Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send initial selections to Python in JupyterChart #3172

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

jonmmease
Copy link
Contributor

Closes #3171

@jonmmease jonmmease requested a review from mattijn August 28, 2023 12:24
@mattijn
Copy link
Contributor

mattijn commented Aug 28, 2023

Thanks @jonmmease! I'm not sure if it is an issue on my side, but the spec from #3171 still retuns an empty selection dictionary after rendering when I checkout this PR on my machine.

Only after manual interaction with the brush selection is the selection dictionary populated (same behavior as prior this PR)

@mattijn
Copy link
Contributor

mattijn commented Aug 28, 2023

Aopolgies. This must have been an issue on my side. After restarting my python session this functions now as intended! Thanks!

@mattijn mattijn merged commit 9b2b0d1 into main Aug 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A chart with defined initial selection is not reflected in the selection store of JupyterChart
2 participants