-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use 'UndefinedLike = Any' as the type hint #2681
Conversation
As is mentioned in this comment: #2614, which counts here as well:
|
Thanks @mattijn ! I believe I've proceeded as you described. I don't know the origin of the (small) changes the script made to Also I should mention that when I first tried to run |
I've no opinion on this. I hope others can review this. If there will not appear any reviewers nor disapprovals I will merge this in two weeks from now. |
I don't have enough expertise to review this properly unfortunately. |
thanks @mattijn ! |
@mattijn quick follow-up -- forgive my ignorance, how does this factor into the version-release cycle? |
It is currently not clear when the next release will be. Work is being done (most notably #2684) to have Altair support the latest features in VegaLite 5 and this will likely results in a major release eventually. Although I could see an argument for making a minor release that fixes some package compatibility issues and deprecations (e.g. #2650 #2683 #2686), I think we also want to focus our efforts so I am not sure that will happen. |
@joelostblom understood, thx! |
Improvement on #2670 -- see summary and discussion there