From 81f3948d7d9f6369fd870b6d47a097adf6da2c2e Mon Sep 17 00:00:00 2001
From: Stefan Binder <binder_stefan@outlook.com>
Date: Sun, 24 Sep 2023 18:20:37 +0200
Subject: [PATCH] Fix remaining mypy errors

---
 altair/vegalite/v5/api.py | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/altair/vegalite/v5/api.py b/altair/vegalite/v5/api.py
index f37ef2c7e..781078170 100644
--- a/altair/vegalite/v5/api.py
+++ b/altair/vegalite/v5/api.py
@@ -1121,8 +1121,7 @@ def __repr__(self) -> str:
     def __add__(self, other) -> "LayerChart":
         if not isinstance(other, TopLevelMixin):
             raise ValueError("Only Chart objects can be layered.")
-        # Too difficult to type check this
-        return layer(self, other)  # type: ignore[arg-type]
+        return layer(self, other)
 
     def __and__(self, other) -> "VConcatChart":
         if not isinstance(other, TopLevelMixin):
@@ -1133,8 +1132,7 @@ def __and__(self, other) -> "VConcatChart":
     def __or__(self, other) -> "HConcatChart":
         if not isinstance(other, TopLevelMixin):
             raise ValueError("Only Chart objects can be concatenated.")
-        # Too difficult to type check this
-        return hconcat(self, other)  # type: ignore[arg-type]
+        return hconcat(self, other)
 
     def repeat(
         self,
@@ -1726,7 +1724,7 @@ def transform_joinaggregate(
         joinaggregate: Union[
             List[core.JoinAggregateFieldDef], UndefinedType
         ] = Undefined,
-        groupby: Union[str, UndefinedType] = Undefined,
+        groupby: Union[List[str], UndefinedType] = Undefined,
         **kwargs: str,
     ) -> Self:
         """
@@ -1807,7 +1805,7 @@ def transform_filter(
             Parameter,
             core.PredicateComposition,
             # E.g. {'not': alt.FieldRangePredicate(field='year', range=[1950, 1960])}
-            TypingDict[str, Union[core.Predicate, str, bool]],
+            TypingDict[str, Union[core.Predicate, str, list, bool]],
         ],
         **kwargs,
     ) -> Self:
@@ -3214,7 +3212,7 @@ def add_selection(self, *selections) -> Self:
         return self.add_params(*selections)
 
 
-def concat(*charts: core.NonNormalizedSpec, **kwargs) -> ConcatChart:
+def concat(*charts, **kwargs) -> ConcatChart:
     """Concatenate charts horizontally"""
     return ConcatChart(concat=charts, **kwargs)
 
@@ -3313,7 +3311,7 @@ def add_selection(self, *selections) -> Self:
         return self.add_params(*selections)
 
 
-def hconcat(*charts: core.NonNormalizedSpec, **kwargs) -> HConcatChart:
+def hconcat(*charts, **kwargs) -> HConcatChart:
     """Concatenate charts horizontally"""
     return HConcatChart(hconcat=charts, **kwargs)
 
@@ -3532,7 +3530,7 @@ def add_selection(self, *selections) -> Self:
         return self.add_params(*selections)
 
 
-def layer(*charts: Union[core.LayerSpec, core.UnitSpec], **kwargs) -> LayerChart:
+def layer(*charts, **kwargs) -> LayerChart:
     """layer multiple charts"""
     return LayerChart(layer=charts, **kwargs)