New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Going to undefined facets causes a 500 error #109

Open

dbrower opened this issue Aug 26, 2015 · 2 comments

Member

dbrower commented Aug 26, 2015

Visiting a facet page which doesn't exist causes a 500 error instead of the expected 404 error. For example, visit https://dl.vecnet.org/catalog/facet/xxx

Member Author

dbrower commented Aug 26, 2015

Some investigation shows this is a blacklight error. Blacklight does not check that @facet is non-nil at this line:

https://github.com/projectblacklight/blacklight/blob/master/lib/blacklight/catalog.rb#L83

Member Author

dbrower commented Oct 1, 2015

Pin the previous link to a specific version of blacklight (since they keep changing the line numbers)
https://github.com/projectblacklight/blacklight/blob/d9e94b5e5f034e286763d80af8c31b85f27f1699/lib/blacklight/catalog.rb#L83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment