host.Compare returns true if one of the variables match

[arpanadhikari]

Hi there!

Not sure if this is a intended behaviour in the sdk, but when comparing two hosts, the sdk returns true if one of the Id, Pool or NameLabel match.

This can be an issue if we're comparing two hosts in the same pool?

code-ref:

func (h Host) Compare(obj interface{}) bool {
	otherHost := obj.(Host)
	if otherHost.Id == h.Id {
		return true
	}
	if h.Pool == otherHost.Pool {
		return true
	}
	if h.NameLabel != "" && h.NameLabel == otherHost.NameLabel {
		return true
	}
	return false
}

Happy to make a pull request if this is considered a potential opportunity for improvement.

[ddelnano]

@arpanadhikari sorry for the late reply! I was traveling the past few weeks.

This code was written with that particular purpose in mind. The only consumer of this client that I'm aware of is the terraform-provider-xenorchestra, where this client code was initially developed.

The idea behind designing it this way was to treat the argument to Client.FindFromGetAllObjects as a filter. Depending on the fields set on the struct (such as the Pool field), it will return anything that matches. The terraform provider needs to filter on all hosts that are within a pool in this way here.

I am planning to rethink how this xo-sdk-go client code works soon (in vatesfr/terraform-provider-xenorchestra#189). So I would love to hear more about how you'd like to use this client and how its existing design isn't solving your use case.

[arpanadhikari]

I see, thanks!