Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix font file name contains space #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pagliacii
Copy link

resolve #273

@Pagliacii Pagliacii force-pushed the fix-font-filename-contains-space branch from b38ebab to 800deee Compare January 8, 2020 08:44
tags Outdated Show resolved Hide resolved
@Pagliacii Pagliacii force-pushed the fix-font-filename-contains-space branch from 800deee to 938b446 Compare January 9, 2020 02:48
@jlu5 jlu5 added the needs-triage issues to be investigated further label Feb 22, 2020
@jlu5
Copy link
Member

jlu5 commented Feb 22, 2020

(Strangely enough, in my testing I'm having issues with loading custom fonts both with and without this patch. Will need to verify this further)

@dnk
Copy link
Contributor

dnk commented Mar 7, 2023

it is need to apply the same change to https://github.com/varietywalls/variety/blob/master/variety/Options.py#L682

grep FONT_NAME . -RI
./variety/VarietyWindow.py: clock_filter = clock_filter.replace("%CLOCK_FONT_NAME", clock_font_name)
./variety/VarietyWindow.py: clock_filter = clock_filter.replace("%DATE_FONT_NAME", date_font_name)
./variety/Options.py: self.clock_filter = "-density 100 -font fc-match -f '%{file[0]}' '%CLOCK_FONT_NAME' -pointsize %CLOCK_FONT_SIZE -gravity SouthEast -fill '#44' -annotate 0x0+[%HOFFSET+58]+[%VOFFSET+108] '%H:%M' -fill white -annotate 0x0+[%HOFFSET+60]+[%VOFFSET+110] '%H:%M' -font fc-match -f '%{file[0]}' '%DATE_FONT_NAME' -pointsize %DATE_FONT_SIZE -fill '#44' -annotate 0x0+[%HOFFSET+58]+[%VOFFSET+58] '%A, %B %d' -fill white -annotate 0x0+[%HOFFSET+60]+[%VOFFSET+60] '%A, %B %d'"
./data/config/variety.conf:clock_filter = "-density 100 -font fc-match -f '%{file[0]}' '%CLOCK_FONT_NAME' -pointsize %CLOCK_FONT_SIZE -gravity SouthEast -fill '#44' -annotate 0x0+[%HOFFSET+58]+[%VOFFSET+108] '%H:%M' -fill white -annotate 0x0+[%HOFFSET+60]+[%VOFFSET+110] '%H:%M' -font fc-match -f '%{file[0]}' '%DATE_FONT_NAME' -pointsize %DATE_FONT_SIZE -fill '#44' -annotate 0x0+[%HOFFSET+58]+[%VOFFSET+58] '%A, %B %d' -fill white -annotate 0x0+[%HOFFSET+60]+[%VOFFSET+60] '%A, %B %d'"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage issues to be investigated further
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SauceCodePro Nerd Font as clock font failed
3 participants