Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spanish translation for async.md #901

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Add Spanish translation for async.md #901

merged 4 commits into from
Sep 14, 2023

Conversation

alemohamad
Copy link
Member

Add Spanish translation for async.md

@alemohamad alemohamad added the translation-update This PR contains translations for the docs label Sep 13, 2023
@alemohamad alemohamad self-assigned this Sep 13, 2023
@alemohamad alemohamad requested review from a team and gwynne as code owners September 13, 2023 18:53
0xTim
0xTim approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll give it a day or two for a native speaker to take a look

jacostaf10
jacostaf10 requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@jacostaf10 jacostaf10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erased some untranslated text left behind and corrected a sentence. The rest is OK.

docs/basics/async.es.md Outdated Show resolved Hide resolved
docs/basics/async.es.md Outdated Show resolved Hide resolved
docs/basics/async.es.md Outdated Show resolved Hide resolved
alemohamad and others added 3 commits September 14, 2023 12:42
@alemohamad
Copy link
Member Author

alemohamad commented Sep 14, 2023 •
edited
Loading

Erased some untranslated text left behind and corrected a sentence. The rest is OK.

Good catch on these @jacostaf10 !

jacostaf10
jacostaf10 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@jacostaf10 jacostaf10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go!

@0xTim 0xTim merged commit b04f5b2 into vapor:main Sep 14, 2023
1 check passed
@alemohamad alemohamad deleted the translation/async-spanish-translation branch September 14, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacostaf10 jacostaf10 jacostaf10 approved these changes

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees

@alemohamad alemohamad

Labels
translation-update This PR contains translations for the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alemohamad @0xTim @jacostaf10