Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Japanese translation #899

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

KaitoMuraoka
Copy link
Contributor

Added Japanese as a new language.

Translated the welcome document.

日本語訳 新しい言語として日本語を追加。

ウェルカムドキュメントを翻訳しました。

@KaitoMuraoka KaitoMuraoka marked this pull request as ready for review September 10, 2023 14:25
@KaitoMuraoka KaitoMuraoka requested review from a team, 0xTim and gwynne as code owners September 10, 2023 14:25
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TonTonbow thank you, this is amazing! Could you also update the search index script - https://github.com/vapor/docs/blob/main/fixSearchIndex.swift? The plugin we use for search doesn't currently play nice with translations so we need to manually disable it for now

@KaitoMuraoka
Copy link
Contributor Author

@0xTim

Thanks for pointing that out! 😄
I've made the edits. Does it look okay like this?

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

@0xTim 0xTim enabled auto-merge (squash) September 12, 2023 15:23
@0xTim 0xTim merged commit 07c625a into vapor:main Sep 12, 2023
1 check passed
@penny-for-vapor penny-for-vapor bot mentioned this pull request Sep 12, 2023
9 tasks
@KaitoMuraoka KaitoMuraoka deleted the feature/japanese-translation branch September 14, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants