Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

[Bug] Reloading or direct loading a subpath within the app leads to a 404 #226

Closed
lsago opened this issue Jan 30, 2024 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@lsago
Copy link

lsago commented Jan 30, 2024

Describe the bug

After interacting with the UI, a user might end up in a path like vantage6-ui.example.org/collaborations. If the user were to refresh/reload, they'd get a 404. This happens for any subpath, even vantage6-ui.example.org/login.

It also happens if the user directly access a subpath, as in, opening vantage6-ui.example.com/login directly.

To Reproduce
Steps to reproduce the behavior:

  1. Go to vantage6-ui.example.com/login
  2. See 404

Expected behavior
Not getting a 404 and the subpath location being loaded.

Details

  • Vantage6-ui 4.2.0

Additional context

If a collaboration has just been created that collaboration will not show up immediately after under /collaborations (this is a separate issue). A way around this is to refresh/reload the page, but this produces a 404. To solve this the user has to go to the main domain for the ui vantage6-ui.example.org and navigate from there to collaborations again. I think the same might go for /users, etc.

This would be nice if a server admin wants to give instruction to a UI-user and sends them a link with a subpath.

@lsago lsago added the bug Something isn't working label Jan 30, 2024
@github-actions github-actions bot added the New label Jan 30, 2024
@bartvanb
Copy link
Member

bartvanb commented Feb 14, 2024

This can be solved by adding a hashtag in the angular path which I did for the old UI here.

Not sure if we still need to release this for the old UI as beta for the new one is already available and old one will be phased out soon. What do you think @lsago?

@lsago
Copy link
Author

lsago commented Feb 14, 2024

Ah, nice. I ended up solving it via a different way. I can push it to a branch for you to check out if you want, let me know.

And I agree, if new UI will be released soon, we can just only have the fix in new version. Do you have an estimate when it will be officially released?

@bartvanb
Copy link
Member

Ah, nice. I ended up solving it via a different way. I can push it to a branch for you to check out if you want, let me know.

I think unless someone really needs this we can leave it to save time. Seeing you already fixed it yourself I don't see a need to do so unless someone else also has this issue

And I agree, if new UI will be released soon, we can just only have the fix in new version. Do you have an estimate when it will be officially released?

It depends on finishing up the algorithm store, for which authorization (in progress) and documentation (under review) still need to be finished. My estimate is a few weeks but no guarantees ;-)

@bartvanb bartvanb removed the New label Mar 14, 2024
@bartvanb
Copy link
Member

Resolved in new UI (I think). Feel free to reopen if you disagree

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants