Fix dependency on redis-cli and redis-server to pass tests #3014
+355
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e places where its assume you have redis-cli, and add the difference distros valkey instalation option Signed-off-by: avifenesh <[email protected]>
…ust package dependencies and improve error handling Signed-off-by: avifenesh <[email protected]>
|
I propose to split this into 3 PRs, because it contains independent features - doc update, node client fixes and core fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to work with Fedora which has strict rules about not OSS packages.
The Redis symlink doesn't exist in the distro because of it. When running tests, they fail, since there are many places we depend on the symlinks to exist.
This pr decouple and allow to developer to have just valkey on their system.
This pr also introduce the way to download Valkey using the package managers of the different distros, since those are not explained yet on Valkey sites.
Issue link
This Pull Request is linked to issue #3011
Checklist
Before submitting the PR make sure the following are checked: