-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add a new implementation of @vaadin/hilla-lit-form
#2620
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the m
object declaration to a separate file because of the value
method. I need it to be overloaded but overloading the object's method is impossible in TS, it's possible only for classes and functions. So I thought that it could be a good idea to make a module with bare functions that could be collected and exported as a single default object.
The drawback of this solution is that I can no longer use the reserved keyword as a name of the function. So, I renamed enum
function to enumeration
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I found that I can export it using export { enumeration as enum }
which removes the drawback
… & improve validators
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
No description provided.