-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarification about package.properties not providing automatic discovery #3929
Comments
From the docs:
From that text I assume that "It supports vaadin.allowed-packages and vaadin.blocked-packages properties in the same way as in the application.properties file" meaning that if I add |
IIRC also the settings in application.properties do not activate any discovery. They simply restrict the packages to scan, that by default is everything. |
@mcollovati start.vaadin.com generates application.properties with |
I wonder if it could be helpful if the vaadin-spring add on would print a warning message for the JAR rules that cannot be applied because of global allowed/blocked list. |
From the description of JAR Packages Scanning it's not clear that "the
package.properties
feature is not about automatically discovering annotated classes in external JARs, but to improve Flow class scanning by allowing JARs to filter out their own unnecessary packages" (as mentioned by @mcollovati in https://vaadin.com/forum/t/any-simple-markdown-viewer/167646/17)If you think this issue is important, add a 👍 reaction to help the community and maintainers prioritize this issue.
The text was updated successfully, but these errors were encountered: