Uyuni remove spacewalk utils extras #9454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmateus
force-pushed
the
uyuni_remove_spacewalk-utils-extras
branch
from
3cac4dc to
60136d9
Compare
rjmateus
force-pushed
the
uyuni_remove_spacewalk-utils-extras
branch
from
60136d9 to
432a438
Compare
mcalmer
approved these changes
Dec 2, 2024
rjmateus
force-pushed
the
uyuni_remove_spacewalk-utils-extras
branch
from
432a438 to
502895f
Compare
remove tool delete-old-systems-interactive Signed-off-by: Ricardo Mateus <[email protected]> remove tool migrate-system-profile Signed-off-by: Ricardo Mateus <[email protected]> remove spacewalk-api tool Signed-off-by: Ricardo Mateus <[email protected]> removes unnecessary dependency Signed-off-by: Ricardo Mateus <[email protected]> remove tool sw-ldap-user-sync Signed-off-by: Ricardo Mateus <[email protected]>
Signed-off-by: Ricardo Mateus <[email protected]>
rjmateus
force-pushed
the
uyuni_remove_spacewalk-utils-extras
branch
from
502895f to
8fbc7bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
remove package spacewalk-.utils-extras and change tools according to the definition at: https://confluence.suse.com/display/~RDiasMateus/SUMA+cmd+tools?focusedCommentId=1649082905#comment-1649082905
To review:
sw-ldap-user-syncto the contrib repo. Should it e the case?spacewalk-watch-channel-sync.shto main package spacewalk-utils.related to: Port uyuni utils extra contrib#30
GUI diff
No difference.
Before:
After:
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE
Links
Issue(s): #
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!