Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2p: Evaluate/Implement LRU cache with configurable size #68

Open
uweseimet opened this issue Feb 18, 2024 · 3 comments
Open

s2p: Evaluate/Implement LRU cache with configurable size #68

uweseimet opened this issue Feb 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request on hold

Comments

@uweseimet
Copy link
Owner

It shall be evaluated whether an LRU cache results in a performance gain. If it does, it shall be implemented with a configurable size. In case it turns out that such a cache outperforms the PiSCSI legacy cache, the latter shall be removed.

@uweseimet uweseimet added the enhancement New feature or request label Feb 18, 2024
@uweseimet uweseimet self-assigned this Feb 18, 2024
@uweseimet uweseimet moved this to Backlog in SCSI2Pi release 3.1 Feb 18, 2024
@bog-dan-ro
Copy link

Isn't better/easier to use mmap and let the kernel worry about caching which is quite good at?

@uweseimet
Copy link
Owner Author

If you want to let the kernel do the work just use one of the non-legacy caching modes, which are filesystem based.

@bog-dan-ro
Copy link

Is not the same thing, each read/write operations requires context switches which are quite expensive...
I forgot to mention that mmap will NOT work for 32bit systems as it won't be able to map files over 2GB, so it's probably a bad idea anyway ...

@uweseimet uweseimet reopened this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold
Projects
None yet
Development

No branches or pull requests

2 participants