Update

cpp/buses/rpi_bus.cpp

@@ -17,9 +17,9 @@ using namespace spdlog;
 
 bool RpiBus::Init(bool target)
 {
-    assert(!target);
+    assert(target);
 
-    Bus::Init(false);
+    Bus::Init(target);
 
     int fd = open("/dev/mem", O_RDWR | O_SYNC);
     if (fd == -1) {
@@ -173,6 +173,9 @@ bool RpiBus::Init(bool target)
 
     CreateWorkTable();
 
+    // Enable ENABLE in order to show the user that s2p is running
+    SetControl(PIN_ENB, ENB_ON);
+
     return true;
 }
 
@@ -293,9 +296,18 @@ bool RpiBus::GetIO()
     return state;
 }
 
-void RpiBus::SetIO(bool)
+void RpiBus::SetIO(bool state)
 {
-    assert(false);
+    assert(IsTarget());
+
+    SetSignal(PIN_IO, state);
+
+    // Change the data input/output direction by IO signal
+    SetControl(PIN_DTD, state ? DTD_OUT : DTD_IN);
+
+    for (int pin : DATA_PINS) {
+        SetMode(pin, state ? OUT : IN);
+    }
 }
 
 inline uint8_t RpiBus::GetDAT()
@@ -359,8 +371,6 @@ void RpiBus::CreateWorkTable(void)
 
 void RpiBus::SetControl(int pin, bool state)
 {
-    assert(!state);
-
     PinSetSignal(pin, state);
 }
 

cpp/s2p/s2p_core.cpp

@@ -452,9 +452,6 @@ void S2p::ProcessScsiCommands()
     while (service_thread.IsRunning()) {
         // Only process the SCSI command if the bus is not busy and no other device responded
         if (bus->WaitForSelection() && WaitForNotBusy()) {
-
-            scoped_lock<mutex> lock(executor->GetExecutionLocker());
-
             // Process command on the responsible controller based on the current initiator and target ID
             if (const auto shutdown_mode = controller_factory.ProcessOnController(bus->GetDAT()); shutdown_mode
                 != shutdown_mode::none) {