Add assertion

uweseimet · Dec 11, 2024 · 2fed7a8 · 2fed7a8
1 parent 19d8863
commit 2fed7a8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/cpp/controllers/abstract_controller.cpp b/cpp/controllers/abstract_controller.cpp
@@ -81,6 +81,12 @@ void AbstractController::SetTransferSize(int length, int size)
 void AbstractController::UpdateTransferSize()
 {
     remaining_length -= chunk_size;
+
+    assert(remaining_length >= 0);
+    if (remaining_length < 0) {
+        remaining_length = 0;
+    }
+
     if (remaining_length < chunk_size) {
         chunk_size = remaining_length;
     }

diff --git a/cpp/controllers/controller.cpp b/cpp/controllers/controller.cpp
@@ -357,7 +357,7 @@ void Controller::Send()
 
     UpdateTransferSize();
 
-    if (GetRemainingLength() > 0) {
+    if (GetRemainingLength()) {
         if (IsDataIn()) {
             TransferToHost();
         }
@@ -444,7 +444,7 @@ void Controller::Receive()
         break;
     }
 
-    if (GetRemainingLength() > 0) {
+    if (GetRemainingLength()) {
         assert(GetCurrentLength());
         assert(!GetOffset());
         return;
@@ -493,7 +493,7 @@ bool Controller::TransferFromHost(int length)
         }
         else {
             length = device->WriteData(GetCdb(), GetBuffer(), -1, length);
-            if (GetRemainingLength() > 0) {
+            if (GetRemainingLength()) {
                 SetCurrentLength(length);
                 ResetOffset();
             }