-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Funny parsing results #84
Comments
@conradludgate might also be interesting for your fork https://github.com/conradludgate/interim, which will be my preferred parser with fallback to this one, because each handles some relative times better:
Irrelevant sidenote: Only chrono-english understands |
For interim, I intended to keep all the quirks of chrono-english for compatibility, but with less panics. I'll admit I haven't given too much thought to the actual cases. I'm open to adding new features if desired |
@conradludgate that would be great, if you could add these I could fully rely on interim: conradludgate/interim#7 |
@xeruf you could please replace your screenshots by text? |
Wrote a small helper to compare to chrono-english.
Apart from #23 and #83, I found some other small issues:
year ago
produces a one-day offset, presumably because of leap years not being accounted fortoday
, while being consistent in both tools, I would expect to refer to the day start rather than the current time-1h1m
should be 61 minutes ago, the preceding minus shall negate the whole expression. It should understand-1h +1m
for 59 minutes ago.The text was updated successfully, but these errors were encountered: